-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Hyperlight KVM guest debugging using gdb #111
Open
dblnz
wants to merge
23
commits into
hyperlight-dev:main
Choose a base branch
from
dblnz:gdb-support-latest
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
34f6813
add basic gdb target for a HLSandbox
dblnz c11143e
create gdb thread when KVM driver is created
dblnz edadd8f
add gdb event loop execution
dblnz 25b424d
remove unnecessary locks
dblnz 5fa8355
pass the necessary handles to the target
dblnz 63dfb87
disable guest timeouts when gdb features is enabled
dblnz 9fb7b2f
add communication channel between gdb and hypervisor
dblnz bc222a5
vcpu state synchronization between hypervisor and gdb client
dblnz 38de187
add target internal state that keeps track whether the vcpu is paused
dblnz f589255
add entrypoint breakpoint support
dblnz 2a144ca
add stop reason transmission to gdb
dblnz e92f1cd
fixup kvm vcpu run
dblnz bbfcad1
add read and write registers support
dblnz a45d5e0
add read/write address and text section offset support
dblnz b917859
add hw breakpoint support
dblnz f8a0e12
add gdb resume capabilities
dblnz 95615ed
add gdb step capabilities
dblnz 11d18c7
rename target file to kvm specific name
dblnz 1322701
change gdb feature to support generics for future improvements
dblnz 35c4f60
fix issues for windows and mshv
dblnz 791aaf8
add documentation about how to debug a guest binary
dblnz 16492de
add sw breakpoint support
dblnz 2a36f06
fix documentation and remove unnecessary comments
dblnz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disabling the timeout might be helpful for scenarios other than debugging too. Might want to put this under a different feature flag or even as a runtime option. Though, that's not too related to this PR, so maybe leaving it like this is OK for now 👍