Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to latest versions of windows crates #147

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

simongdavies
Copy link
Contributor

@simongdavies simongdavies commented Jan 20, 2025

#144 Bump Windows from 0.58 to 0.59
#133 Bump windows-result from 0.2 to 0.3

There are a couple of API signature changes in the windows crate which are addressed in this PR.

@simongdavies simongdavies added the area/dependencies Pull requests that update a dependency file label Jan 20, 2025
@simongdavies simongdavies force-pushed the update-windows-crates branch 3 times, most recently from 654041b to f3f4217 Compare January 21, 2025 09:47
dblnz
dblnz previously approved these changes Jan 22, 2025
Copy link
Contributor

@dblnz dblnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ludfjig
ludfjig previously approved these changes Jan 23, 2025
@simongdavies simongdavies dismissed stale reviews from ludfjig and dblnz via 305a527 January 27, 2025 10:43
@simongdavies simongdavies force-pushed the update-windows-crates branch 2 times, most recently from 305a527 to 57c844d Compare January 27, 2025 13:33
Copy link
Contributor

@syntactically syntactically left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@syntactically
Copy link
Contributor

/lgtm /approve

Copy link
Contributor

@marosset marosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@syntactically syntactically merged commit 7ed76e8 into hyperlight-dev:main Jan 27, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants