#300: openpanel/savepanel: ensure files can be selected in file chooser #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperpenelope
force-pushed
the
dev/v1.0.8
branch
from
02e9fcd to
5d06ada
Compare
hyperpenelope
force-pushed
the
dev/openpanel-file-chooser-shows-dirs-not-files
branch
from
12bd571 to
e08bfe7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #300 on the mothership repository.
Also changes the behaviour when savepanel is triggered and the file chooser returns a path where no file exists. Currently, a non-existent path is treated as an error, and the path is not passed to the
savepanelsymbol in the patch. However, this prevents a user from saving audio to a new file. This PR removes the check for the existence of a file at the path returned by the file chooser (when this was triggered by savepanel).