-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a dummy event to left-align results in slider #67
Conversation
This is my attempt to fix the centered-image issue with bxSlider. We talked about adding a dummy event with a blank image whenever there is only one result, so that the result will left-align. This code does that by adding a dummy event to the database that can be used anywhere by calling
I'm now wondering whether it might be better practice to append the dummy on the frontend. This would avoid muddying backend logic and a need for a dummy event in the db. I realize it would add to the work for Clearbold but I think it would be feasible for them to do it...and given the issues I raised above, they'd probably need to do some altering of their code anyway to account for these conditionals. @jamiefolsom let's discuss sometime soon. |
I just saw this #69. To be continued... |
If it helps, I think we'll initially just force an extra 3 items in every rendering on Staging so that we can evaluate the formatting stuff first, holding off on basing that on dummy API items or conditional logic. Based on where we're at and the items to wrap up, I think I'm as wary of tackling additional conditional logic as you are loading up the API with these until we sort out the interface :) |
No description provided.