Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add timeout verifying client interceptor #60

Merged
merged 1 commit into from
May 31, 2024

Conversation

aaron-steinfeld
Copy link
Contributor

Description

Because we want every call to be made with a timeout, this interceptor (which will be attached by the service framework) highlights any calls missing one.

@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner May 30, 2024 21:52
Copy link

Test Results

82 tests  ±0   82 ✅ ±0   18s ⏱️ -2s
14 suites ±0    0 💤 ±0 
14 files   ±0    0 ❌ ±0 

Results for commit 48be592. ± Comparison against base commit f12cdf4.

Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 77.66%. Comparing base (f12cdf4) to head (48be592).

Files Patch % Lines
...tils/client/TimeoutVerifyingClientInterceptor.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #60      +/-   ##
============================================
- Coverage     78.46%   77.66%   -0.81%     
  Complexity      172      172              
============================================
  Files            23       24       +1     
  Lines           483      488       +5     
  Branches         26       26              
============================================
  Hits            379      379              
- Misses           80       85       +5     
  Partials         24       24              
Flag Coverage Δ
unit 77.66% <0.00%> (-0.81%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aaron-steinfeld aaron-steinfeld merged commit 1c57c76 into main May 31, 2024
5 of 7 checks passed
@aaron-steinfeld aaron-steinfeld deleted the missing-timeout-interceptor branch May 31, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants