-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle 429 status code in response gracefully. #21
base: master
Are you sure you want to change the base?
Conversation
@igusar-epam, @dyurchenko-epam could you take a look at it? That change would prevent us from internal library crash on internal check. And would allow us to not fork HW SDK, but use original one. |
Now we just get:
so the original cause is obscured. |
@m-aciek I think this change is ok. I can approve this pull request if you add me as a reviewer. Also you can add @aseveryn-hw to this discussion. He has a lot more experience in SDK programming. |
@igusar-epam thank you! But it looks like I don't have permissions to assign a review :( [1]. |
@m-aciek I added myself as a reviewer and approved it. I also added other team members to it. |
@vkorotchenko @wmews-hw @aseveryn-hw what do you think of this small change? |
@wmews-hw Hi, I've corrected my pull request. Could you take a look? |
Closes #20.