-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement random sort and dynamic timeline sorting via dropdown #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, good work on the initial pass.
I think we could have a cleaner hasMore
logic by having the reader track the current count vs how many items total are in the notes collection.
Also instead of storing notes in an array we should render them out as we get them. For duplicates, we can just not bother tracking duplicate notes when rendering the randomized timeline.
Also, we should start doing a page render before ingesting followed accounts to improve initial load.
… sort=0 for randomization
…for better UX in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! :)
22310ee