Make Popover a presentational component #1857
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1857 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 70 70
Lines 1306 1306
Branches 482 482
=========================================
Hits 1306 1306 ☔ View full report in Codecov by Sentry. |
|
I'm putting this back as draft, as it may not be needed in the end. |
|
As described above, the motivation for this was supporting proper accessibility in at-mentions (see hypothesis/client#6769), but for that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
Popovera presentational component, accepting any DIV HTML attribute which is passed down to the outermost div.The motivation for this PR is that we needed to be able to pass an
idtoPopover. Since I imagine we may need to add more arbitrary attributes in future, I checked how we handle similar components, and PresentationalComponents seemed like a reasonable approach.