Ensure Select onScroll is bound to the Popover, not the listbox #1864
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression that was likely introduced when the
Popover
component was implemented.That made the
Select
'sonListboxScroll
to never be invoked again, as due to the new DOM structure, the element that ends up with scroll is not the listbox, but the popover itself.This PR deprecates
onListboxScroll
, and adds a newonPopoverScroll
prop to replace it (its default value is whatever was passed toonListboxScroll
, for backwards compatibility), and also makes sure theonPopoverScroll
is passed to the right DOM element.