Merge pull request estheban#14 from toiine/fix-issue-13_undefined-null

fixed bug with undefined and null values
hzspeed · Mar 17, 2015 · 28e1a6c · 28e1a6c
2 parents c4720fc + 1d5401c
commit 28e1a6c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/json2xml.js b/lib/json2xml.js
@@ -53,6 +53,8 @@ module.exports = function xml(json, opts) {
 				var node = json[key],
 				attributes = '';
 
+                if(typeof node === 'undefined' || null === node) node = '';
+
 				if(opts.attributes_key && json[opts.attributes_key]){
 					Object.keys(json[opts.attributes_key]).forEach(function(k){
 						attributes += util.format(' %s="%s"', k, json[opts.attributes_key][k]);

diff --git a/test/json2xml_test.js b/test/json2xml_test.js
@@ -32,16 +32,18 @@ exports['json2xml'] = {
     test.done();
   },
   'opts': function(test) {
-    test.expect(6);
+    test.expect(8);
     test.equal(json2xml({a:''}),'<a/>');
+    test.equal(json2xml({a:null}),'<a/>');
+    test.equal(json2xml({a:undefined}),'<a/>');
 
     test.equal(json2xml({a:1}),'<a>1</a>');
     test.equal(json2xml([{a:1}, {b:2}]),'<a>1</a><b>2</b>');
 
     test.equal(json2xml({ 'items':[{item:1},{item:2}]} ),'<items><item>1</item><item>2</item></items>');
 
     test.equal(json2xml({a:1}, { header:true }),'<?xml version="1.0" encoding="UTF-8"?><a>1</a>');
-    test.equal(json2xml({a:1, attr:{b:2,c:3 }}, { attributes_key:'attr' }), '<a b="2" c="3">1</a>'); 
+    test.equal(json2xml({a:1, attr:{b:2,c:3 }}, { attributes_key:'attr' }), '<a b="2" c="3">1</a>');
     test.done();
   }