Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tool): add sql database query tool #24

Merged
merged 10 commits into from
Sep 24, 2024
Merged

feat(tool): add sql database query tool #24

merged 10 commits into from
Sep 24, 2024

Conversation

abughali
Copy link
Contributor

Which issue(s) does this pull-request address?

New SQL Database Tool.

Description

This pull request introduces a new SQL tool to the framework. The following updates are included:

  • Main tool code under src/tools/database
  • Updated environment template for multiple database dialects (SQLite, MySQL, PostgreSQL, etc.)
  • Integrated the sequelize and sqlite3 package in dev and peer dep.
  • Unit and E2E testing.
  • Sample SQL Agent.
  • Documentation: updated main README.md. Added docs/sql-tool.md.

Checklist

  • I have read the contributor guide
  • Linting passes: yarn lint or yarn lint:fix
  • Formatting is applied: yarn format or yarn format:fix
  • Unit tests pass: yarn test:unit
  • E2E tests pass: yarn test:e2e
  • Tests are included
  • Documentation is changed or added
  • Commit messages and PR title follow conventional commits

@Tomas2D Tomas2D self-requested a review September 20, 2024 08:52
Tomas2D
Tomas2D requested changes Sep 20, 2024
View reviewed changes
examples/agents/sql.ts Outdated Show resolved Hide resolved
src/tools/database/sql.ts Outdated Show resolved Hide resolved
src/tools/database/sql.ts Outdated Show resolved Hide resolved
src/tools/database/sql.ts Outdated Show resolved Hide resolved
src/tools/database/connection.ts Outdated Show resolved Hide resolved
src/tools/database/connection.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Tomas2D
Tomas2D requested changes Sep 21, 2024
View reviewed changes
src/tools/database/sql.ts Outdated Show resolved Hide resolved
src/tools/database/sql.ts Outdated Show resolved Hide resolved
@abughali abughali requested a review from Tomas2D September 23, 2024 11:51
Tomas2D
Tomas2D requested changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@Tomas2D Tomas2D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allow a user to pass connection config instead of loading them from ENV.

@abughali abughali requested a review from Tomas2D September 23, 2024 20:02
Tomas2D
Tomas2D requested changes Sep 23, 2024
View reviewed changes
src/tools/database/sql.ts Outdated Show resolved Hide resolved
src/tools/database/sql.ts Outdated Show resolved Hide resolved
src/tools/database/metadata.ts Outdated Show resolved Hide resolved
src/tools/database/metadata.ts Outdated Show resolved Hide resolved
src/tools/database/metadata.ts Outdated Show resolved Hide resolved
src/tools/database/metadata.ts Show resolved Hide resolved
src/tools/database/sql.ts Show resolved Hide resolved
@abughali abughali requested a review from Tomas2D September 24, 2024 01:12
Tomas2D
Tomas2D approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@Tomas2D Tomas2D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🚀 Thank you for the contribution 👍🏻

@Tomas2D Tomas2D merged commit 719d80d into i-am-bee:main Sep 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomas2D Tomas2D Tomas2D approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abughali @Tomas2D