Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch cursor focus to root after removing a tag with focus #66

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

i-like-robots
Copy link
Owner

@i-like-robots i-like-robots commented Feb 14, 2024

Currently when removing a tag that has focus the cursor is shifted to the input element. This behaviour automatically opens the listbox which can be annoying.

This refactors the behaviour to shift cursor focus to the component root instead, giving the user the choice of where to navigate next whilst remaining in context. I have also fixed a bug whereby focus may be lost after deleting multiple tags.

Resolves #61

@i-like-robots i-like-robots added the bug Something isn't working label Feb 14, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7898381856

Details

  • 0 of 9 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 93.107%

Totals Coverage Status
Change from base Build 7651766260: 0.007%
Covered Lines: 1486
Relevant Lines: 1601

💛 - Coveralls

@i-like-robots i-like-robots merged commit 528b278 into main Feb 14, 2024
3 checks passed
@i-like-robots i-like-robots deleted the focus-root branch February 14, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collapse the list box if user is removing a selected tag
2 participants