-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update babel-plugin-tester to v11 #1784
Conversation
Report too large to display inline |
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is known malware?This package is malware. We have asked the package registry to remove it. It is strongly recommended that malware is removed from your codebase. What is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
babel-plugin-tester v8 started prettifying snapshots so they all had to be updated.
@@ -19,81 +19,81 @@ pluginTester({ | |||
babelOptions: { filename: __filename, parserOpts: { plugins: ['jsx'] } }, | |||
tests: [ | |||
` | |||
import { Trans } from '../icu.macro' | |||
import { Trans } from '../../../icu.macro' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
babel-plugin-tester v11 has na updated structure so the import parts had to be updated as well.
|
||
const count = 2; | ||
const outside = number\`\${count}\`; | ||
`, | ||
snapshot: false, | ||
error: /"number``" can only be used inside <Trans> in "[^"]+" on line 5/, | ||
error: /"number``" can only be used inside <Trans> in "[^"]+" on line 6/, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely sure about this one but I think babel-plugin-tester v11 either changed now it reports errors or adds an line to the top of files it tests because all the errors are now reported on the line below what they did in previous versions.
Description
Updates babel-plugin-tester to v11 (latest)
Checklist
npm run test