Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update eslint-plugin-testing-library to v6 #1792

Merged
merged 2 commits into from
Aug 14, 2024
Merged

chore: update eslint-plugin-testing-library to v6 #1792

merged 2 commits into from
Aug 14, 2024

Conversation

ripecosta
Copy link
Contributor

Description

Updates eslint-plugin-testing-library to v6.
Disables the testing-library/no-manual-cleanup rule, which is now active by default on the testing-library/react config, because vitest doesn't expose global afferEach methods.

Note: The lint step in failing in CI for an unrelated reason, which is fixed in #1791.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

"happy-dom": "^14.12.3",
"husky": "^9.1.4",
"i18next": "^23.12.2",
"lint-staged": "^15.2.8",
"lint-staged": "^15.2.9",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary but updated it while I was here.

@ripecosta ripecosta changed the title Rc/eslint testing library chore: update eslint-plugin-testing-library to v6 Aug 14, 2024
@coveralls
Copy link

Coverage Status

coverage: 97.073%. remained the same
when pulling d151f48 on ripecosta:rc/eslint-testing-library
into e068e5e on i18next:master.

@adrai adrai merged commit 0fd1620 into i18next:master Aug 14, 2024
8 of 9 checks passed
@ripecosta ripecosta deleted the rc/eslint-testing-library branch August 14, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants