Feature/mixer #1
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| /.vscode/ | ||
| /samples/ | ||
| *.wav |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| package compressor | ||
|
|
||
| //Compressor interface for sound compressor's | ||
| type Compressor interface { | ||
| Compress(notCompressedSound float64) float64 | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| package compressor | ||
|
|
||
| //DynamicRangeCompressor can process operation that reduces the volume of loud sounds | ||
| //Treadshold it is a volume-level above which it is necessary to begin compression | ||
| //Attack it is a delay for begin compression after exceeding the threshold | ||
| //release it is a time while compression will work | ||
| //compretionRatio it is a coefficient by which the signal will be multiplied | ||
| type DynamicRangeCompressor struct { | ||
| threshold float64 | ||
| attack int | ||
| release int | ||
| compretionRatio float64 | ||
|
|
||
|
|
||
| attackTimer int | ||
| releaseTimer int | ||
|
|
||
| isInitialize bool | ||
| thresholHasBeenExceeded bool | ||
|
|
||
| } | ||
|
|
||
| //NewDynamicRangeCompressor creates new DynamicRangeCompressor to process sounds | ||
| func NewDynamicRangeCompressor(threshold, compretionRatio float64, attack, release int) *DynamicRangeCompressor { | ||
|
There was a problem hiding this comment. It's convenient to use a struct instead of obscure parameter lists: |
||
| return &DynamicRangeCompressor{ | ||
| threshold: threshold, | ||
| attack: attack, | ||
| attackTimer: attack, | ||
| release: release, | ||
| compretionRatio: compretionRatio, | ||
| isInitialize: true, | ||
| } | ||
| } | ||
|
|
||
| //Compress sound | ||
| func (d *DynamicRangeCompressor) Compress(notCompressedSound float64) float64 { | ||
|
|
||
| if d == nil || !d.isInitialize { | ||
| panic("dynamicRangeCOmpressor must be initialized. Use NewCompressor function") | ||
| } | ||
|
|
||
| compressedSound := notCompressedSound | ||
|
|
||
| if notCompressedSound > d.threshold { | ||
| d.releaseTimer = d.release | ||
|
There was a problem hiding this comment. Can |
||
| d.thresholHasBeenExceeded = true | ||
| } | ||
|
|
||
| if d.attackTimer == 0 && d.releaseTimer == 0 && d.thresholHasBeenExceeded { | ||
|
There was a problem hiding this comment. Looks like it's possible to do this without |
||
| d.attackTimer = d.attack | ||
| d.thresholHasBeenExceeded = false | ||
| compressedSound = d.compressFunction(notCompressedSound) | ||
|
|
||
| } else if d.attackTimer == 0 && d.releaseTimer > 0 { | ||
| compressedSound = d.compressFunction(notCompressedSound) | ||
| d.releaseTimer-- | ||
|
|
||
| } else if d.thresholHasBeenExceeded { | ||
| d.attackTimer-- | ||
| } | ||
|
|
||
| return compressedSound | ||
| } | ||
|
|
||
| func (d *DynamicRangeCompressor) compressFunction(notCompressedSound float64) float64 { | ||
| return notCompressedSound * d.compretionRatio | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| package compressor | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| . "github.com/onsi/ginkgo" | ||
| . "github.com/onsi/gomega" | ||
| ) | ||
|
|
||
| var _ = Describe("DynamicRangeCompressor", func() { | ||
|
|
||
| It("Should return same value", func() { | ||
|
|
||
| compressor := NewDynamicRangeCompressor(2.0, 0.5, 1, 2) | ||
|
|
||
| Expect(0.5).To(Equal(compressor.Compress(0.5))) | ||
| Expect(0.5).To(Equal(compressor.Compress(0.5))) | ||
| Expect(0.5).To(Equal(compressor.Compress(0.5))) | ||
| Expect(0.5).To(Equal(compressor.Compress(0.5))) | ||
| Expect(0.5).To(Equal(compressor.Compress(0.5))) | ||
| Expect(0.5).To(Equal(compressor.Compress(0.5))) | ||
| Expect(0.5).To(Equal(compressor.Compress(0.5))) | ||
| }) | ||
|
|
||
| It("Should return compresed value with attack delay", func() { | ||
| compressor := NewDynamicRangeCompressor(1.9, 0.5, 1, 2) | ||
|
|
||
| Expect(2.0).To(Equal(compressor.Compress(2.0))) | ||
| Expect(1.0).To(Equal(compressor.Compress(2.0))) | ||
| Expect(0.5).To(Equal(compressor.Compress(1.0))) | ||
| Expect(0.5).To(Equal(compressor.Compress(1.0))) | ||
| Expect(1.0).To(Equal(compressor.Compress(1.0))) | ||
| Expect(1.0).To(Equal(compressor.Compress(1.0))) | ||
| }) | ||
|
|
||
| It("Should return compresed value without attack delay", func() { | ||
| compressor := NewDynamicRangeCompressor(1.9, 0.5, 0, 2) | ||
|
|
||
| Expect(1.0).To(Equal(compressor.Compress(2.0))) | ||
| Expect(0.5).To(Equal(compressor.Compress(1.0))) | ||
| Expect(0.5).To(Equal(compressor.Compress(1.0))) | ||
| Expect(1.0).To(Equal(compressor.Compress(1.0))) | ||
| Expect(5.0).To(Equal(compressor.Compress(10.0))) | ||
| Expect(0.5).To(Equal(compressor.Compress(1.0))) | ||
| }) | ||
|
|
||
| It("Should return compresed value without attack delay and witout release delay", func() { | ||
| compressor := NewDynamicRangeCompressor(1.9, 0.5, 0, 0) | ||
|
|
||
| Expect(1.0).To(Equal(compressor.Compress(2.0))) | ||
| Expect(1.0).To(Equal(compressor.Compress(2.0))) | ||
| Expect(1.0).To(Equal(compressor.Compress(1.0))) | ||
| Expect(1.0).To(Equal(compressor.Compress(1.0))) | ||
| Expect(5.0).To(Equal(compressor.Compress(10.0))) | ||
| Expect(1.0).To(Equal(compressor.Compress(1.0))) | ||
| }) | ||
| }) | ||
|
|
||
| func TestCompressor(t *testing.T) { | ||
| RegisterFailHandler(Fail) | ||
| RunSpecs(t, "Compressor Suite") | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| package compressor | ||
|
|
||
| //MockCompressorImpl this is mock for interface Compressor. Hi does nothing. | ||
| type MockCompressorImpl struct { | ||
| } | ||
|
|
||
| //Compress just return same value | ||
| func (m MockCompressorImpl) Compress(notCompressedSound float64) float64 { | ||
| return notCompressedSound | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Go interfaces are usually defined in user packages. So
Mixershould define what it accepts as aCompressor.