Fixing texture bleeding issues #20
Conversation
| // Fill texture with transparent pixels | ||
| for (int x = 0; x < SHEET_SIZE; x++) { | ||
| for (int y = 0; y < SHEET_SIZE; y++) { | ||
| texture.SetPixel(x, y, new Color(0, 0, 0, 0)); |
There was a problem hiding this comment.
SetPixel is probably slow within the loop. SetPixels32 is probably faster, but I believe the fastest solution is to pass a byte array of zeros to LoadRawTextureData.
Also, all the functions above require Apply to upload data from CPU to GPU. Maybe the final output could look something like:
var texture = new Texture2D(SHEET_SIZE, SHEET_SIZE, TextureFormat.RGBA32, false);
texture.LoadRawTextureData(new byte[SHEET_SIZE * SHEET_SIZE * 4]);
texture.Apply(false, EmojiTexture.CanCopyTextures);
var spriteAsset = ScriptableObject.CreateInstance<TMP_SpriteAsset>();
//...
There was a problem hiding this comment.
I'm ok if you commit your own version to master)
There was a problem hiding this comment.
Apologies for the holdup, currently working on a larger refactor and support for different platforms, so I didn't get the time to do this earlier. I will include this in the next commit :)
|
Thank you again for your contribution, that's a valid point (and it should be noticeable as well, even though I didn't notice it before, probably because of screen resolution, maybe) |
Empty tiles in emoji spritesheet are filled with gray color that can lead to texture bleeding issues.