Selected events without data #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Devgen8
reviewed
May 24, 2023
Comment on lines
10
to
16
| // MARK: - Events ViewInput | ||
| protocol SelectedEventsModelInput: AnyObject { | ||
| } | ||
|
|
||
| // MARK: - Events ViewOutput | ||
| protocol SelectedEventsModelOutput: AnyObject { | ||
| } |
| import Foundation | ||
|
|
||
| // MARK: - Events ViewInput | ||
| protocol SelectedEventsModuleInput: AnyObject { |
Comment on lines
24
to
25
| private extension SelectedEventsPresenter { | ||
| } |
Comment on lines
33
to
34
| extension SelectedEventsPresenter: SelectedEventsModelOutput { | ||
| } |
Devgen8
requested changes
May 27, 2023
| @@ -108,7 +108,8 @@ final class AddingEventViewController: UIViewController { | |||
| floor: floor ?? " ", | |||
| room: ofice ?? " ", | |||
| description: eventDescription ?? " ", | |||
| isLiked: false) | |||
| isLiked: false, | |||
| userID: "22") | |||
Comment on lines
45
to
46
| isLiked: false, | ||
| userID: "") |
Comment on lines
108
to
109
| let moduleInput: EventsModuleInput? | ||
| moduleInput?.loadPlacemarks() |
There was a problem hiding this comment.
А в чем идея? moduleInput всегда nil будет
| @@ -51,12 +51,17 @@ final class EventsService: EventsServiceDescription { | |||
| } | |||
| func storeAddingData(event: Event, coordinatesId: String, completion: @escaping (Result<Event, Error>) -> Void) { | |||
| var ref: DocumentReference? | |||
| guard let userID = FBManager.auth.currentUser?.uid else { | |||
| return | |||
There was a problem hiding this comment.
completion еще нужно дернуть
Events module
JRNS-28: Stuff list addition to trips
JRNS: Theme bug fix
JRNS-48: Added account avatar
linlinich
added
Ждет ревью
JRNS-46: Dark theme and weather CollectionView reload fixes
JRNS-53: Map dark theme
open EventVC on tap MapCell
Lost some files fix
JRNS-45: Alerts localization
Devgen8
requested changes
May 29, 2023
Comment on lines
177
to
178
| guard let address = output?.displayAddress() else { return "No address" } | ||
| return address |
There was a problem hiding this comment.
output?.displayAddress() ?? "No address"
| service.storeAddingData(event: newEvent, coordinatesId: coordinatesId) { [weak self] result in | ||
| guard let strongSelf = self else { return } | ||
| isLiked: false, | ||
| userID: "") |
There was a problem hiding this comment.
Почему в userId всегда какие-то рандомные значения передаются?)
| @@ -4,13 +4,13 @@ | |||
| // | |||
| // Created by Ангелина Решетникова on 25.04.2023. | |||
| // | |||
|
|
|||
| import FirebaseFirestore | |||
Comment on lines
+147
to
+148
| userLocationLayer.isHeadingEnabled = true | ||
| userLocationLayer.isHeadingEnabled = false |
There was a problem hiding this comment.
очень похоже на трюки, то эта штука переносит тебя в твое местоположение поэтому я включаю она переносит и выключаю
| @@ -99,6 +158,34 @@ class EventsViewController: UIViewController { | |||
| private func didTapFavouritesButton() { | |||
| output?.didTapFavouritesButton() | |||
| } | |||
| //MARK: YMKUserLocationObjectListener protocol | |||
|
|
|||
| @objc(onObjectAddedWithView:) func onObjectAdded(with view: YMKUserLocationView) { | |||
There was a problem hiding this comment.
Лучше названия для objc над методом писать, так более емко получается
Comment on lines
195
to
196
| let image = | ||
| eventCell.configure(data: data, delegate: self, indexPath: indexPath) |
There was a problem hiding this comment.
Странно, что на разных строках
Devgen8
added
Ждет исправлений
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.