Rk2 #2
Open
Rk2 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agscpp
suggested changes
Dec 12, 2023
|
|
||
| import UIKit | ||
|
|
||
| class BaseController: UIViewController{ |
| override func viewDidLoad() { | ||
| super.viewDidLoad() | ||
| view.backgroundColor = .systemBackground | ||
| title = "History" |
Comment on lines
+31
to
+34
| view.backgroundColor = .systemBackground | ||
| title = "History" | ||
| setUpData() | ||
| setUpCollectionView() |
There was a problem hiding this comment.
лучше еще сделать общий setup и вызывать оттуда другие setup и делать общие настройки
Comment on lines
+47
to
+48
| cellWidth = view.frame.width - 10 | ||
| cellHeight = 50 |
There was a problem hiding this comment.
Константы лучше вынести, как и цвета в отдельный файл. В дальнейшем будет удобно, что в одном месте и едины для всего проекта
Comment on lines
+53
to
+56
| collectionView.widthAnchor.constraint(equalToConstant: cellWidth), | ||
| collectionView.bottomAnchor.constraint(equalTo: view.safeAreaLayoutGuide.bottomAnchor), | ||
| collectionView.leadingAnchor.constraint(equalTo: view.leadingAnchor, constant: 5), | ||
| collectionView.trailingAnchor.constraint(equalTo: view.trailingAnchor, constant: -5) |
There was a problem hiding this comment.
Здесь конфликта по констрейтам не будет? У вас сейчас получается и ширина задания и по краям он прибит к view
Comment on lines
+29
to
+31
| // tabBar.barTintColor = Resourses.Colors.inactive | ||
| // tabBar.backgroundColor = .systemBackground | ||
| tabBar.layer.borderColor = Resourses.Colors.separator.cgColor |
There was a problem hiding this comment.
Можно "// TODO" и комментарий какой-то чтобы в будущем не забыть выпилить подобное
Comment on lines
+33
to
+37
|
|
||
|
|
||
|
|
||
|
|
||
|
|
|
|
||
| let tabBarController = TabBarController() | ||
|
|
||
| window=UIWindow(frame: windowScene.coordinateSpace.bounds) |
Comment on lines
+13
to
+14
|
|
||
|
|
Comment on lines
+44
to
+52
| contentView.addSubview(positionLabel) | ||
| contentView.addSubview(driverLabel) | ||
| contentView.addSubview(timeLabel) | ||
| contentView.addSubview(pointsLabel) | ||
|
|
||
| positionLabel.translatesAutoresizingMaskIntoConstraints = false | ||
| driverLabel.translatesAutoresizingMaskIntoConstraints = false | ||
| timeLabel.translatesAutoresizingMaskIntoConstraints = false | ||
| pointsLabel.translatesAutoresizingMaskIntoConstraints = false |
There was a problem hiding this comment.
Можно написать чуть более компактно
[positionLabel, driverLabel, timeLabel, pointsLabel].forEach {
$0.translatesAutoresizingMaskIntoConstraints = false
contentView.addSubview($0)
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.