Remove assignement of all config properties in base Layer class #2368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desplandis
force-pushed
the
remove/layer-assign
branch
6 times, most recently
from
ca64d3d
to
6ba93e7
Compare
|
Nice! Can you rebase and fix the failing test please ? Then I can review it |
Desplandis
force-pushed
the
remove/layer-assign
branch
from
6ba93e7
to
f2418e4
Compare
|
@jailln Rebased and ready to go! |
jailln
reviewed
Nov 7, 2024
Desplandis
force-pushed
the
remove/layer-assign
branch
from
f2418e4
to
1fe883e
Compare
jailln
approved these changes
Nov 26, 2024
Desplandis
force-pushed
the
remove/layer-assign
branch
from
1fe883e
to
e3e92aa
Compare
Desplandis
force-pushed
the
remove/layer-assign
branch
from
e3e92aa
to
b0663ff
Compare
|
Rebased, RTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to remove the call to
Object.assign(this, config)in theLayerclass and move-up all properties initialisation in their respective classes. The goal of this refactoring is triple: ease the understanding of itowns logic (side-effects, initialisation, etc...), type-checking and a first step to clean-up configurations and layers.Closes #2368