Update module resolution and provide mandatory file extensions #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank99
reviewed
Oct 1, 2024
There was a problem hiding this comment.
I haven't looked deeply through all the file changes (I'm assuming that build passes means everything is generally ok), but I did have one comment on the tsconfig.
Also, you might want to add these two settings to your vscode settings to help with auto-import:
"javascript.preferences.importModuleSpecifierEnding": "js",
"typescript.preferences.importModuleSpecifierEnding": "js",
mayank99
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR changes
moduleResolutionused in AppUI packages fromNodetoNodeNext. This change required mandatory file extensions to be provided in import declarations https://nodejs.org/api/esm.html#mandatory-file-extensionsAdditionally, the
moduleis changed as well to be compatible with the newmoduleResolution.classnamesandimmerpackage versions are updated to solve some of the export problems caused by new module resolution.CJS modules are dropped from a private
@itwin/appui-test-providerspackage.Testing
N/A