Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace playwright type calls with fill #225

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Conversation

johnnyd710
Copy link
Contributor

Using locator.fill is the recommended way to fill out input, and Page.type is now deprecated.

I made these changes using pnpm patch for my Electron application, and I think it will close #224 but I can't be sure because the issue is flaky and doesn't happen frequently.

@ben-polinsky
Copy link
Collaborator

Looks good, but integration tests are now failing. Could you look into why?

@johnnyd710
Copy link
Contributor Author

Looks good, but integration tests are now failing. Could you look into why?

The basic.test.t > failure with invalid Bentley federated user integration test was entering the [email protected] username twice (another reason not to use type) and the test was checking for Enter a valid email address, phone number, or Skype name. which is the incorrect thing to test for.
image

It should be checking for This username may be incorrect. Make sure you typed it correctly. for the case of an invalid username but correctly formatted email, like it does now that fill replaces the input text instead of adding to it.

image

@johnnyd710
Copy link
Contributor Author

Now its failing on mac because ErrorResponse: Authorization code is invalid or expired. ?

@ben-polinsky
Copy link
Collaborator

Now its failing on mac because ErrorResponse: Authorization code is invalid or expired. ?

Re-running...

@johnnyd710 johnnyd710 merged commit 909f2cc into main Dec 12, 2023
12 checks passed
@johnnyd710 johnnyd710 deleted the john/playwright-fill branch December 12, 2023 15:35
@ben-polinsky
Copy link
Collaborator

Thanks @johnnyd710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@itwin/oidc-signin-tool password is not always filled in
3 participants