-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to drape the background map onto reality meshes. #7401
Conversation
@pmconne Paul, the change I'm wondering about is in RealityModelTileTree:addToScene. Currently the display setting for the draping cannot turn off the draping if it is set in the model tile data with the doDrapeBackgroundMap flag. I'm actually not sure how we would tell that they wanted it to override it anyhow since the bgMapDrape flag is off by default in the RealityMeshDisplaySettings unless we change this from a boolean to an enum and provide a third option for overriding what the tiles say. |
@MarcNeely the flag on the tileset indicates a rare, legacy scalable mesh export whose texture imagery comes from a map service instead of being baked in to the tiles. To me, that seems orthogonal to your new RealityMeshDisplaySettings flag that controls whether or not we replace the tileset's texture imagery with map imagery. Kinda like how overriding an element's color to blue would have no visible effect if the element is already intrinsically blue. |
@MarcNeely any update on this? will it be completed? |
@markschlosseratbentley can we close this in favor of #7637? |
#7637 is more about draping model map layers. @MarcNeely can likely comment further on whether this one should be kept open. |
Draping map imagery onto reality models (this PR) is a requirement for iTwin Experience, which will be using Cesium.js as its renderer. We don't need to implement this feature in the iTwin.js renderer. This PR can be closed. Someone will need to determine whether Cesium.js already provides this capability, or otherwise file an issue in that repo. #7637 is needed in iTwin.js renderer. |
This ability already somewhat existed. This PR simply exposes it more so that context reality models which are meshes as well as other reality models which are meshes can have the background map draped onto them as well at will. This is done by adding a RealityMeshDisplaySettings member to the RealityModelDisplaySettings class.
This is a partial fix for issue #6214