Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated supported node version range in rush #311

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Updated supported node version range in rush #311

merged 3 commits into from
Feb 23, 2024

Conversation

hl662
Copy link
Contributor

@hl662 hl662 commented Feb 23, 2024

  • Bumps up supported node version in rush, matching that in itwinjs core. Also update rush and pnpm version to support node 20
  • Ran rush update, which auto modifies some common/scripts files that rush uses
  • Update webpack version in desktop-viewer-test to address high security vulnerability

Tested CI workflow and ran desktop viewer test using latest version of node 20

@hl662 hl662 self-assigned this Feb 23, 2024
aruniverse
aruniverse reviewed Feb 23, 2024
View reviewed changes
rush.json Show resolved Hide resolved
@hl662 hl662 added this pull request to the merge queue Feb 23, 2024
Merged via the queue into master with commit b4d784d Feb 23, 2024
4 checks passed
@hl662 hl662 deleted the nam/rush-node-range-bump branch February 23, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aruniverse aruniverse aruniverse approved these changes

@ben-polinsky ben-polinsky Awaiting requested review from ben-polinsky ben-polinsky is a code owner

@calebmshafer calebmshafer Awaiting requested review from calebmshafer calebmshafer is a code owner

Assignees

@hl662 hl662

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hl662 @aruniverse