update to ^1.0 of new presentation pkgs #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aruniverse
requested review from
ben-polinsky and
calebmshafer
as code owners
saskliutas
approved these changes
Oct 31, 2024
I suppose with the tree widget's bump to iTwinUI 3.x... full stack: t polymorphic.js:6:34
at SingleSelectButton (Select.js:363:29)
at div (<anonymous>)
at polymorphic.js:6:34
at Select.js:333:9
at div (<anonymous>)
at polymorphic.js:6:34
at Select.js:98:18
at Select.js:23:9
at div (<anonymous>)
at div (<anonymous>)
at ControlledSelectableContent (SelectableContent.tsx:48:11)
at SelectableContent (SelectableContent.tsx:111:11)
at div (<anonymous>)
at SelectableTreeContent (SelectableTree.tsx:58:18)
at SelectableTree (SelectableTree.tsx:49:43)
at ErrorBoundary (react-error-boundary.development.esm.js:12:1)
at div (<anonymous>)
at SelectableTreeWidget (TreeWidgetUiItemsProvider.tsx:89:36)
at $44d7e150ebc754d2$export$e926676385687eaf (ErrorBoundary.ts:20:8)
at div (<anonymous>)
at ScrollableWidgetContent (Content.tsx:28:26)
at div (<anonymous>)
at polymorphic.js:6:34
at ThemeProvider.js:111:9
at ThemeProvider.js:97:56
at ToastProvider (Toaster.js:61:33)
at HydrationProvider (HydrationProvider.js:17:37)
at ScopeProvider (ScopeProvider.js:7:33)
at ThemeProvider.js:28:1
at PopoutThemeProvider (PopoutThemeProvider.tsx:24:39)
at WidgetContent (Content.tsx:38:18)
at div (<anonymous>)
at WidgetContentRenderer (ContentRenderer.tsx:53:38)
at WidgetContentRenderers (ContentRenderer.tsx:25:25)
at PreviewHorizontalPanelAlignFeatureProvider (PreviewHorizontalPanelAlign.tsx:52:3)
at MaximizedWidgetProvider (MaximizedWidget.tsx:30:3)
at WidgetPanelsFrontstageComponent (Frontstage.tsx:69:65)
at WidgetContentManager (ContentManager.tsx:22:31)
at CursorTypeProvider (NineZone.tsx:191:31)
at DraggedResizeHandleProvider (DragManager.tsx:581:25)
at DraggedPanelSideProvider (DragManager.tsx:572:23)
at DraggedWidgetIdProvider (DragManager.tsx:563:27)
at DragProvider (DragManager.tsx:530:23)
at NineZoneProvider (NineZone.tsx:87:47)
at NineZone (NineZone.tsx:62:11)
at div (<anonymous>)
at ActiveFrontstageDefProvider (Frontstage.tsx:212:3)
at WidgetPanelsFrontstage (Frontstage.tsx:186:47)
at div (<anonymous>)
at polymorphic.js:6:34
at ThemeProvider.js:111:9
at ThemeProvider.js:97:56
at ToastProvider (Toaster.js:61:33)
at HydrationProvider (HydrationProvider.js:17:37)
at ScopeProvider (ScopeProvider.js:7:33)
at ThemeProvider.js:28:1
at main (<anonymous>)
at ConfigurableUiContent (ConfigurableUiContent.tsx:93:26)
at div (<anonymous>)
at ThemeProvider.js:75:13
at ThemeProvider.js:37:13
at div (<anonymous>)
at polymorphic.js:6:34
at ThemeProvider.js:111:9
at ThemeProvider.js:97:56
at ToastProvider (Toaster.js:61:33)
at HydrationProvider (HydrationProvider.js:17:37)
at ScopeProvider (ScopeProvider.js:7:33)
at ThemeProvider.js:28:1
at ThemeManager (ThemeManager.tsx:58:32)
at IModelViewer (IModelViewer.tsx:32:3)
at Provider (Provider.js:8:1)
at div (<anonymous>)
at IModelLoader.tsx:36:5
at ErrorBoundary (ErrorBoundary.tsx:16:1)
at BaseViewer (BaseViewer.tsx:17:3)
at Viewer (Viewer.tsx:15:46)
at div (<anonymous>)
at App (App.tsx:44:43) |
So at runtime, everything does work... I would like to see if we can defer the itiwnui v3 update of the viewer to next major. Maybe we could do it in a minor, but would like to do it separately from this pr if possible |
ben-polinsky
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.