Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to appui 5 #343

Merged
merged 6 commits into from
Jan 8, 2025
Merged

update to appui 5 #343

merged 6 commits into from
Jan 8, 2025

Conversation

aruniverse
Copy link
Member

@aruniverse aruniverse commented Jan 6, 2025 •
edited
Loading

todo in another pr:

  • revisit deprecated appui apis exposed in our types
  • fix tests (but we will need to move to vitest, so defer)
  • review if we need our own ui providers or if should just appui's

@aruniverse
Copy link
Member Author

fyi @GerardasB if you have any concerns/comments on the migration here

@aruniverse aruniverse marked this pull request as ready for review January 7, 2025 16:27
@aruniverse aruniverse requested a review from GerardasB January 7, 2025 16:27
@aruniverse aruniverse merged commit e34f635 into next Jan 8, 2025
2 checks passed
@aruniverse aruniverse deleted the appui-5 branch January 8, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-polinsky ben-polinsky ben-polinsky approved these changes

@GerardasB GerardasB GerardasB approved these changes

@calebmshafer calebmshafer Awaiting requested review from calebmshafer calebmshafer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aruniverse @GerardasB @ben-polinsky