Fix memory leaks with LineItem

iakov · Oct 28, 2024 · 2d31485 · 2d31485
1 parent 255135e
commit 2d31485
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/plugins/robots/common/twoDModel/src/engine/items/stylusItem.cpp b/plugins/robots/common/twoDModel/src/engine/items/stylusItem.cpp
@@ -31,6 +31,11 @@ StylusItem::StylusItem(qreal x1, qreal y1)
 	mTmpY1 = y1;
 }
 
+StylusItem::~StylusItem()
+{
+	qDeleteAll(mAbstractListLine);
+}
+
 AbstractItem *StylusItem::clone() const
 {
 	const auto cloned = new StylusItem(x1(), y1());
@@ -148,6 +153,7 @@ QDomElement StylusItem::serialize(QDomElement &parent) const
 void StylusItem::deserialize(const QDomElement &element)
 {
 	AbstractItem::deserialize(element);
+	qDeleteAll(mAbstractListLine);
 	mAbstractListLine.clear();
 	recalculateProperties();
 

diff --git a/plugins/robots/common/twoDModel/src/engine/items/stylusItem.h b/plugins/robots/common/twoDModel/src/engine/items/stylusItem.h
@@ -27,7 +27,7 @@ class StylusItem : public ColorFieldItem
 
 public:
 	StylusItem(qreal x1, qreal y1);
-
+	~StylusItem() override;
 	AbstractItem *clone() const override;
 
 	/// Creates and returns colored stylus item for 2D model palette.

diff --git a/qrtranslations/fr/plugins/robots/twoDModel_fr.ts b/qrtranslations/fr/plugins/robots/twoDModel_fr.ts
@@ -373,7 +373,7 @@
 <context>
     <name>twoDModel::items::StylusItem</name>
     <message>
-        <location filename="../../../../plugins/robots/common/twoDModel/src/engine/items/stylusItem.cpp" line="+54"/>
+        <location filename="../../../../plugins/robots/common/twoDModel/src/engine/items/stylusItem.cpp" line="+59"/>
         <source>Stylus (S)</source>
         <translation>Stylo (S)</translation>
     </message>

diff --git a/qrtranslations/ru/plugins/robots/twoDModel_ru.ts b/qrtranslations/ru/plugins/robots/twoDModel_ru.ts
@@ -649,7 +649,7 @@
 <context>
     <name>twoDModel::items::StylusItem</name>
     <message>
-        <location filename="../../../../plugins/robots/common/twoDModel/src/engine/items/stylusItem.cpp" line="+54"/>
+        <location filename="../../../../plugins/robots/common/twoDModel/src/engine/items/stylusItem.cpp" line="+59"/>
         <source>Stylus (S)</source>
         <translation>Стилус (S)</translation>
     </message>