Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mistune and add escape parameter #108

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

Bass-03
Copy link
Contributor

@Bass-03 Bass-03 commented Sep 15, 2023

I noticed mistune was pinned to version 0.8.4, I updated it to v 3.0.1 (which covers #81 and #82 ((sorry))), all tests passing too.

While at it, I added the escape parameter mentioned on #34, which enables the rendering of quotes and other symbols instead of html escaped symbols.
I added that to the library but not to the CLI, the default is to not escape HTML stuff.

My main goal is to be able to get unescaped HTML, mainly for linking other confluence pages and maybe adding macros as mentioned on #34, But I though the new Mistune could handle it, let's see if that works.

@schneiderl
Copy link

Hey @Bass-03 Thanks a lot for this.

@iamjackg Any way we can get this merged upstream and released?

In Mistune through 2.0.2, there is a Regular Expression Denial of Service (ReDoS) flaw.
From CVE-2022-34749:

In mistune through 2.0.2, support of inline markup is implemented by using regular expressions that can involve a high amount of backtracking on certain edge cases. This behavior is commonly named catastrophic backtracking.

@iamjackg iamjackg changed the base branch from master to develop October 22, 2023 00:26
Copy link
Owner

@iamjackg iamjackg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for submitting this :) Left some comments.

setup.py Outdated Show resolved Hide resolved
test_package/functional/test.md Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@schneiderl
Copy link

Thank you both for looking into this.

And thank you @iamjackg for the tool, it is very helpful 😄

@schneiderl
Copy link

Hey @iamjackg @Bass-03

Any updates on this? I'm happy to hop in and make any changes if necessary.

@Bass-03 Bass-03 requested a review from iamjackg November 23, 2023 15:18
@Bass-03
Copy link
Contributor Author

Bass-03 commented Nov 23, 2023

hey @schneiderl
I think I did all changes needed, we are waiting for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants