Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some handling for tag edge cases #118

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add some handling for tag edge cases #118

wants to merge 3 commits into from

Commits on Nov 13, 2023

  1. Add some handling for tag edge cases 

    - Properly handle updating tags if the page doesn't already have them
- JSON-ify tags so Confluence can properly consume the data

Fixes iamjackg#117
    @nate-woythaler
    nate-woythaler committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    3bbc5e3 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Tidy get calls to make testing easier 

    Chaining the `get` calls would mean a messy amount of Mocks. Just use a
single `get` call and if it's empty return a dummy struct for sanity's
sake.

Also `get('name')` on the returned struct since we run into issues with
Mocking without it.

Fixes iamjackg#117
    @nate-woythaler
    nate-woythaler committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    cb62db9 View commit details
    Browse the repository at this point in the history

  2. Fix broken unit tests by mocking metadata

    @nate-woythaler
    nate-woythaler committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    7c0f1ed View commit details
    Browse the repository at this point in the history