Keep gauges in sync with GC.stat #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Envek
reviewed
Oct 31, 2024
There was a problem hiding this comment.
Thank you for the pull request! I like the approach!
Can you please run rubocop -A and drop the check heap_allocatable_pages from the spec (seems that it has gone from Ruby 3.4)?
Seems that this pull request doesn't allow edit from maintainers, so I can't push fixes myself.
|
@Envek sure, done |
jeremy
force-pushed
the
all-gc-stats
branch
3 times, most recently
from
73a1dd9 to
e06677c
Compare
Omit defunct stats and support new ones automatically. Stats without a verbose comment default to their own name since the Prometheus exporter requires one. Example on Ruby 3.4.0-preview2: ```ruby >> GC.stat.keys - Yabeda.gc.methods(false) => [:heap_empty_pages, :heap_allocatable_slots] >> Yabeda.gc.methods(false) - GC.stat.keys => [:heap_sorted_length, :heap_allocatable_pages, :heap_tomb_pages] ```
|
Released in 0.4.0, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omit defunct stats and support new ones automatically.
Example on Ruby 3.4.0-preview2. Before:
After: