This repository has been archived by the owner on Mar 22, 2021. It is now read-only.
Allow running the command once again #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still testing this on fork |
|
lol there's a derp |
Recently, Magneto was modified such that it throws an exception if the area is modified during application runtime, if it has been set previously. This extension sets it prior to regenerating the URLs. Additional work attempted to repair this change by checking if the area code was set. However, this has not functioned as expected (at least in the most recent version of Magento), as Magento throws an exception on querying an area code that has not already been set. This commit modifies the setter such that it attempts to set the application state during runtime, and on failure, preserves it as is. This allows upstream to make the decision as to what state should be set, but provides a sane fallback in the case it does not.
andrewhowdencom
force-pushed
the
ad-hoc-fix-run
branch
from
69d53fa to
f15fdbe
Compare
|
I am at least 75% sure this works. I will check it again tomorrow |
|
Yah seems fine |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, Magneto was modified such that it throws an exception if the
area is modified during application runtime, if it has been set
previously. This extension sets it prior to regenerating the URLs.
Additional work attempted to repair this change by checking if the area
code was set. However, this has not functioned as expected (at least in
the most recent version of Magento), as Magento throws an exception on
querying an area code that has not already been set.
This commit modifies the setter such that it attempts to set the
application state during runtime, and on failure, preserves it as is.
This allows upstream to make the decision as to what state should be
set, but provides a sane fallback in the case it does not.