-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pattern name bug fix #6
Conversation
… id and name when generating fi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the indicated gap in the logic that prevents the pattern renaming to take place and we'll be good to go.
src/main/java/com/conveyal/gtfs/validator/PatternFinderValidator.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now! Please fix one tiny formatting glitch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great approach, thanks!
Checklist
dev
before they can be merged tomaster
)Description
Update to use the pattern ids and names provided with a feed to the patterns generated in the pattern finder. The pattern ids are then used in the pattern builder to generate pattern stops with the correctly related pattern ids.
Related DT PR: ibi-group/datatools-server#586