Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern name bug fix #6

Merged
merged 7 commits into from
Jan 24, 2024
Merged

Pattern name bug fix #6

merged 7 commits into from
Jan 24, 2024

Conversation

br648
Copy link

@br648 br648 commented Jan 16, 2024

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

Update to use the pattern ids and names provided with a feed to the patterns generated in the pattern finder. The pattern ids are then used in the pattern builder to generate pattern stops with the correctly related pattern ids.

Related DT PR: ibi-group/datatools-server#586

Copy link

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the indicated gap in the logic that prevents the pattern renaming to take place and we'll be good to go.

@br648 br648 assigned binh-dam-ibigroup and unassigned br648 Jan 22, 2024
Copy link

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now! Please fix one tiny formatting glitch.

@br648 br648 assigned miles-grant-ibigroup and unassigned br648 Jan 23, 2024
Copy link

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great approach, thanks!

@br648 br648 merged commit a8a376c into dev Jan 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants