Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordering of location group and location group stop data #9

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

br648
Copy link

@br648 br648 commented Nov 11, 2024

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

The GTFS-lib for efficiency reads one row from a CSV file and writes that directly to the matching table. Unfortunately this prevents parsing/reordering of the data to suit DT. This update (besides creating a new util class for CSV reading) intercepts requests to read location groups or location group stops and reorders the data prior to it being read into the database.

This ultimately allows the database row id to represent the same location group id in location groups and location group stops. Yes, a lot of effort just to order some data, but hey.

Copy link

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is working. Thanks so much

@br648 br648 merged commit fbee3c7 into dev-flex Nov 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants