OTP-1458 Provide traveler with continue instruction #268
Conversation
|
|
||
| return Stream.of( | ||
| Arguments.of( | ||
| monitoredTrip, | ||
| createPoint(firstStepCoords, 1, NORTH_EAST_BEARING), | ||
| "IMMEDIATE: Head WEST on Adair Avenue Northeast", |
There was a problem hiding this comment.
I think we'll need the plain text to keep track of the kinds of instructions expected. Or, we can further break down the instructions, this one could be a "directional" instruction for instance.
There was a problem hiding this comment.
It would be cleaner to further break down the instruction. Also, this way eliminates time zone issues. But I think that is out of scope. Let me know.
|
|
||
| @Override | ||
| public String build() { | ||
| if (isNotEmpty(legStep) && isNotEmpty(legStep.streetName)) { |
There was a problem hiding this comment.
For objects, can we use != null and for strings, Strings.isBlank (or what is the rationale for pulling in a new library)?
| Locale locale | ||
| ) { | ||
| if (!travelerPosition.expectedLeg.transitLeg && nextStep != null) { | ||
| Step currentStep = isPositionPastStep(travelerPosition, nextStep) |
There was a problem hiding this comment.
At times, this piece produces the incorrect street name. I'll send an example where the behavior is not what you/d expect.
There was a problem hiding this comment.
I've reworked this. Seems to work ok now with the example you provided.
br648
changed the title
binh-dam-ibigroup
deleted the
feature/OTP-1458-replace-no-instruction-on-walk-leg
branch
Checklist
devbefore they can be merged tomaster)Description
Provide a "continue on street" reassurance instruction when the traveler is on track, but no immediate instruction is available.