Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MobilityProfile): Correctly assign "Some" profile #269

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

binh-dam-ibigroup
Copy link
Collaborator

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • [na] The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

This PR provides a fix for the situation where users indicated mobility restrictions, no devices were seeing the same travel speeds as users with no mobility limitations.

Copy link
Contributor

@JymDyerIBI JymDyerIBI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Simple enough, looks good to me.

Copy link
Contributor

@br648 br648 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@br648 br648 assigned binh-dam-ibigroup and unassigned br648 Nov 20, 2024
@binh-dam-ibigroup binh-dam-ibigroup merged commit 62ac8df into dev Nov 20, 2024
2 checks passed
@binh-dam-ibigroup binh-dam-ibigroup deleted the fix-mobility-modes branch November 20, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants