Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete push devices on account deletion #270

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Delete push devices on account deletion #270

merged 2 commits into from
Nov 21, 2024

Conversation

binh-dam-ibigroup
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup commented Nov 15, 2024 •
edited
Loading

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • [na] The description lists all applicable issues this PR seeks to resolve
  • [na] The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

This PR adds deletion of registered devices on account deletion.

JymDyerIBI
JymDyerIBI approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@JymDyerIBI JymDyerIBI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Also straightforward. Looks good to me.

amy-corson-ibigroup
amy-corson-ibigroup approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@binh-dam-ibigroup binh-dam-ibigroup merged commit 7a00826 into dev Nov 21, 2024
2 checks passed
@binh-dam-ibigroup binh-dam-ibigroup deleted the delete-push-devices branch November 21, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JymDyerIBI JymDyerIBI JymDyerIBI approved these changes

@amy-corson-ibigroup amy-corson-ibigroup amy-corson-ibigroup approved these changes

Assignees

@binh-dam-ibigroup binh-dam-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@binh-dam-ibigroup @amy-corson-ibigroup @JymDyerIBI