Correctly unsnooze snoozed trips #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
br648
approved these changes
Nov 28, 2024
Did it unsnooze a trip if you let it run? On mine it didn't, I'll investigate. |
Never mind, the previous try might have been a flake. |
|
As mentioned in the team meeting, it is the wrong check (if you snooze a monitored trip on a day the trip does not happen, it will not unsnooze), so I'll take it back. |
|
@br648 and @JymDyerIBI Ready for review again! |
br648
approved these changes
Dec 3, 2024
| } | ||
|
|
||
| private static Stream<Arguments> createCanUnsnoozeTripCases() { | ||
| // (Trips from above response above starts on Tuesday, June 9, 2020 at 8:40am and ends at 8:58am.) |
There was a problem hiding this comment.
Nit. "Trips from above response start on Tuesday".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
This PR fixes an issue where monitoring on snoozed trip did not resume automatically the next calendar day.