fix(subsettings-pane): move const outside of callback

ibi-group · Sep 24, 2024 · 5ba1bb3 · 5ba1bb3
1 parent 46ee93f
commit 5ba1bb3
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/packages/trip-form/src/MetroModeSelector/SubSettingsPane.tsx b/packages/trip-form/src/MetroModeSelector/SubSettingsPane.tsx
@@ -189,13 +189,14 @@ export default function SubSettingsPane({
     { settingsNoSubmodes: [], settingsOnlySubmodes: [] }
   );
 
+  // rental mode settings do not have type "SUBMODE"
+  const settingsWithTransportMode = modeButton.modeSettings.filter(
+    (s: ModeSetting) =>
+      (s.type === "CHECKBOX" || s.type === "SUBMODE") && s.addTransportMode
+  );
+
   const handleSettingChange = useCallback(
     (setting: ModeSetting) => (evt: QueryParamChangeEvent) => {
-      // rental mode settings do not have type "SUBMODE"
-      const settingsWithTransportMode = modeButton.modeSettings.filter(
-        (s: ModeSetting) =>
-          (s.type === "CHECKBOX" || s.type === "SUBMODE") && s.addTransportMode
-      );
       // check if setting is a transport mode setting
       if (settingsWithTransportMode.find(s => s.key === setting.key)) {
         // check if all submodes are disabled