Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable stop filtering radius #30

Merged
merged 6 commits into from
May 8, 2024

Conversation

miles-grant-ibigroup
Copy link
Collaborator

The stop filtering radius was fixed to 4 digits. Now we can configure that to make it less sensitive.

env.example.yml Outdated Show resolved Hide resolved
utils.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Great work

Copy link

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind suffixing the new config param name with "digits"?

env.example.yml Outdated Show resolved Hide resolved
Copy link

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@miles-grant-ibigroup miles-grant-ibigroup merged commit 7f7e460 into master May 8, 2024
1 check passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the configurable-stop-filtering-radius branch May 8, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants