Skip to content

Commit

Permalink
Merge pull request #21 from ibi-group/upgrade-node
Browse files Browse the repository at this point in the history
Correctly specify node 18 version
  • Loading branch information
miles-grant-ibigroup authored Jun 22, 2023
2 parents 01a56fe + fdd9806 commit 246709a
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/node-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ jobs:

steps:
- uses: actions/checkout@v2
- name: Use Node.js 16.x
- name: Use Node.js 18.x
uses: actions/setup-node@v1
with:
node-version: 16.x
node-version: 18.x
- name: Install npm packages using cache
uses: bahmutov/npm-install@v1
- name: Lint code
Expand Down
4 changes: 3 additions & 1 deletion next.config.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
/** @type {import('next').NextConfig} */
const fs = require('fs')
const { Readable } = require('stream')
const { finished } = require('stream/promises')

const withYaml = require('next-plugin-yaml')

Expand All @@ -20,7 +22,7 @@ module.exports = async () => {
)
const downloadedConfig = await fetch(CONFIG_YML_URL)
const fileStream = fs.createWriteStream('./config.yaml')
await downloadedConfig.body.pipe(fileStream)
await finished(Readable.fromWeb(downloadedConfig.body).pipe(fileStream))
console.log(`Downloaded config.yaml`)
}
return withYaml(nextConfig)
Expand Down
4 changes: 1 addition & 3 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
{
"name": "survey",
"version": "0.1.0",
"engines": {
"node": "<18"
},
"engines": { "node": "18.x" },
"scripts": {
"dev": "next dev",
"build": "next build",
Expand Down

3 comments on commit 246709a

@vercel
Copy link

@vercel vercel bot commented on 246709a Jun 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

atlrides-survey – ./

atlrides-survey-ibi-group.vercel.app
atlrides-survey.vercel.app
atlrides-survey-git-dev-ibi-group.vercel.app

@vercel
Copy link

@vercel vercel bot commented on 246709a Jun 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

qa-survey – ./

qa-survey.vercel.app
qa-survey-git-dev-ibi-group.vercel.app
qa-survey-ibi-group.vercel.app

@vercel
Copy link

@vercel vercel bot commented on 246709a Jun 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

st-survey – ./

st-survey-git-dev-ibi-group.vercel.app
st-survey.vercel.app
st-survey-ibi-group.vercel.app

Please sign in to comment.