Refactor get_datasets functionality #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the TimeSeriesPreprocessor to deprecate
get_datasetsfunctionality.Create new standalone function
get_datasetswhich takes a TimeSeriesPreprocessor -- functionally equivalent to previousget_datasets.Create new standalone function
prepare_data_splitswhich splits the input dataframe according to the split config. This function is used byget_datasets.Rationale:
In some cases, notably when using the time series forecasting pipeline, we need to split the dataframes in the same way as
get_datasetsbut we do not require pytorch datasets.Addresses discussion in: #53