Fixes - Django 5.0 django.utils.timezone.utc removal, handle comma in function in column, import os #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace django.utils.timezone.utc with datetime.timezone.utc
Django 4.1 fix
- handle db functions where a comma is used to delimit parameters - handle db functions (ie, CAST) that use "AS xxxx" (ie, varchar) where it is not an alias
- handle db functions where a comma is used to delimit parameters - handle db functions (ie, CAST) that use "AS xxxx" (ie, varchar) where it is not an alias
lsmoker
changed the title
|
@praveen-db2 Please review this PR and have your approval. Thanks. |
|
@praveen-db2 Please review this code change. Thanks. |
|
@lsmoker our adapter doesnt support Django 5.0 yet. We will merge this PR once we test this against Django test suites. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace django.utils.timezone.utc (removed in 5.x) with datetime.timezone.utc