Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add icon and badges in ReadMe #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add icon and badges in ReadMe #1

wants to merge 1 commit into from

Conversation

llxia
Copy link

@llxia llxia commented Nov 30, 2022

Signed-off-by: Lan Xia [email protected]

@llxia
Copy link
Author

llxia commented Nov 30, 2022 •
edited
Loading

image

@llxia
Copy link
Author

llxia commented Nov 30, 2022

@aprenaud @mstoodle @AdamBrousseau could you please review? Thanks

AdamBrousseau
AdamBrousseau reviewed Dec 1, 2022
View reviewed changes
Copy link
Contributor

@AdamBrousseau AdamBrousseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we will be adding this to all the binary repos?

README.md
</p>
<br />

[![Download latest](https://img.shields.io/github/downloads/ibmruntimes/semeru11-certified-binaries/latest/total)](https://github.com/ibmruntimes/semeru11-certified-binaries/tags)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "latest" redundant if we are keeping this list current?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the latest is the same as jdk-11.0.17+8_openj9-0.35.0 at the moment. The latest will always point to the new release at the time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, do we need/want both?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can be helpful in the future when the download stats for the new release is not added in time.

README.md

<p align="center">
<a href="https://developer.ibm.com/languages/java/semeru-runtimes/">
<img src="./SemeruRuntimes.svg" alt="Semeru" width="200">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will defer to Tony/Mark on approving the icon usage.

@llxia
Copy link
Author

llxia commented Dec 1, 2022 •
edited
Loading

I assume we will be adding this to all the binary repos?

Yes, that is my plan. I am trying out in this repo first. If there are any other badges that you would like to see, please let me know. For example, I can add Docker Pulls number in OE repos. Or I can add Slack/Twitter if we have one.

AdamBrousseau
AdamBrousseau approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@AdamBrousseau AdamBrousseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine with me. I'm not sure what other badges we'd be interested in but we can add later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamBrousseau AdamBrousseau AdamBrousseau approved these changes

@aprenaud aprenaud Awaiting requested review from aprenaud

@mstoodle mstoodle Awaiting requested review from mstoodle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@llxia @AdamBrousseau