Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sysmacros.h and chdir_long #25

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Add sysmacros.h and chdir_long #25

merged 2 commits into from
Jul 7, 2023

Conversation

IgorTodorovskiIBM
Copy link
Collaborator

  • chdir_long is not exposed in a header in Linux, it's just defined - this will help resolve the gnulib issues
  • sys/sysmacros.h is used a variety of ports - usually it's guarded for with an alternate implementation but not in the case of procps.

MikeFultonDev
MikeFultonDev approved these changes Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@MikeFultonDev MikeFultonDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you havent can you open an issue to properly implement chdir_long?
Otherwise lgtm

@IgorTodorovskiIBM IgorTodorovskiIBM mentioned this pull request Jul 7, 2023
Open
@IgorTodorovskiIBM
Copy link
Collaborator Author

Thanks, opened #26

@IgorTodorovskiIBM IgorTodorovskiIBM merged commit 407db3e into zopen Jul 7, 2023
@IgorTodorovskiIBM IgorTodorovskiIBM deleted the add_sysmacros branch July 7, 2023 12:51
IgorTodorovskiIBM added a commit that referenced this pull request Dec 3, 2023
@IgorTodorovskiIBM
Merge zopen branch into main (#36)
cfd28b0 
* Add sysmacros.h and chdir_long (#25)

* Add sys/sysmacros.h + chdir_long

* Fix makedev

* Add support for _ENCODE_FILE_NEW + enable man pages (#27)

* Enable V2R5 system builds when targetting V2R4 (#28)

* Workaround for configure issues when building in V2R5+

* fixup

* fixup

* Update zos-v2r5-symbolfixes.h

* Include zos.h rather tha zos-base.h for version information in zos.cc

* Add more v2r5 symbols to include/zos-v2r5-symbolfixes.h (#30)

* Add more v2r5 symbols to include/zos-v2r5-symbolfixes.h

* Update zos-v2r5-symbolfixes.h

* Update zos-v2r5-symbolfixes.h with more functions (#31)

* Update __threading_support

* Carry over fixes from internal main branch

* Fix fopen_ascii for untagged files (#32)

* Add __getprogramdir, getprogname, getloadavg (#33)

* Add getloadavg

* Add getprogname and __getprogramdir

* Add getprogname and __getprogramdir

* Fix comment in getloadvg

* Add details for how to find CCT offsets/descriptions

* Fix typo

* Update zos-v2r5-symbolfixes.h (#34)

Add shm_open to the list

* Remove dupe bfdcache_destroyed

* Fix style and indention in zos-io.cc

* Rename program info tests + misc fixes

* Rename test-new-programinfo.cc to test-programinfo.cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeFultonDev MikeFultonDev MikeFultonDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IgorTodorovskiIBM @MikeFultonDev