[Feature Branch] React Functional Conversions #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Convert Dashboard to functional component it would be shorter to list what didn't change. Everything changes? useEffect replacing compnentDidMount No more weird handling of filter values, let API filtering do it's job Cleaned up small behaviors around button enabling State use makes way more sense now dashboard_id is sanely synced when direct navigation via URL don't wait for promise repsonse to set modal open state
mshriver
changed the title
Buggy, really needs to be on top of the dashboard conversion and not straight against main. the rendering/useEffect is not right, select flickers open Migrate to react-toastify Remove eventEmitter for notifications, use react-toastify Styling isn't amazing but it should follow dark/light theme and uses the PF alert component. Removed before/after upload hooks as they're unnecessary for our scope and implementation, they were only used for notifications and with react-toastify container I just moved that functionality into the file upload component itself. Move theme to context, update masthead Correctly reads browser preference or local storage to set theme on login, and track theme selection in IbutsuContext masthead can't be themed correctly in PF5, update on migration to PF6. Apply some styling to the toolbar buttons in the masthead Change theme select to ToggleGroup, following PF design guidelines JSDOM mock for window.matchMedia
Context wasn't being used correctly in sidebar Move behavior to useEffect to fetch views on project selection
Pretty straightforward migration, dropped one unused state item for total pages. Had to use callback functions for the useEffect hookst
* Convert user-dropdown to functional * address linting issues
* removed pf5 class from dropdown items * rely only on setState methods to update dropdown state * remove eventEmitter from IbutsuHeader
Please enter the commit message for your changes. Lines starting
new file for WidgetHeader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening a PR to observe the delta between the react migration branch and main.
https://issues.redhat.com/browse/IQE-3308