Type of RecurrencePattern.Until is CalDateTime #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axunonb
force-pushed
the
pr/recurrence-pattern-until
branch
2 times, most recently
from
35001b2 to
b54664d
Compare
minichma
previously approved these changes
Feb 11, 2025
| : untilCalDt.ToTimeZone(reference.TzId).Value; | ||
| ? untilCalDt | ||
| // convert to the reference timezone and convert the value to Floating | ||
| : untilCalDt.ToTimeZone(reference.TzId).Value.AsCalDateTime(); |
There was a problem hiding this comment.
We should have a more elegant way of converting between floating and non-floating. Can't we write .ToTimeZone(null)? I feel that we should actually have something like CalDateTime.AsFloating() and CalDateTime.WithZoned(tzId) (which is not a topic of this PR and which is in contrast to my comments in a previous discussion - I know)
There was a problem hiding this comment.
OMG, of course, this is implemented already: ToTimeZone(reference.TzId).ToTimeZone(null), as simple as that 👍
axunonb
force-pushed
the
pr/recurrence-pattern-until
branch
from
b54664d to
1f622ab
Compare
Update ArgumentException to ArgumentOutOfRangeException in RecurrencePatternSerializer
axunonb
force-pushed
the
pr/recurrence-pattern-until
branch
from
1f622ab to
6a9ba25
Compare
|
This was referenced Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed type of
RecurrencePattern.UntilfromDateTimetoCalDateTimeChange
ArgumentExceptiontoArgumentOutOfRangeExceptioninRecurrencePatternSerializerResolves #588
Resolves #653