Telegram notifications + replies. #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ice-ares
reviewed
Jul 1, 2024
notifications/DDL.sql
Outdated
Comment on lines
23
to
24
| ALTER TABLE users ADD COLUMN IF NOT EXISTS telegram_user_id text NOT NULL; | ||
| ALTER TABLE users ADD COLUMN IF NOT EXISTS telegram_bot_id text NOT NULL; |
There was a problem hiding this comment.
Not gonna work. U need a func that sets it atomically.
- Add nullable column if not exists
- Update column, set value = user_id
- Alter table make column not null
U have examples in eskimo/santa/husky how to do that
There was a problem hiding this comment.
Or atleast tell me the exact sql to run
There was a problem hiding this comment.
Actually no, lets make both columns nullable. And just handle the select with a coalesce
notifications/DDL.sql
Outdated
| @@ -45,7 +49,7 @@ CREATE TABLE IF NOT EXISTS scheduled_notifications ( | |||
| notification_channel_value TEXT NOT NULL, | |||
| primary key(user_id,uniqueness,notification_type,notification_channel,notification_channel_value)); | |||
| CREATE UNIQUE INDEX IF NOT EXISTS scheduled_notifications_i_ix ON scheduled_notifications (i); | |||
| CREATE INDEX IF NOT EXISTS scheduled_notifications_mod_i_ix ON scheduled_notifications (MOD(i, %[1]v), scheduled_for ASC); | |||
| CREATE INDEX IF NOT EXISTS scheduled_notifications_mod_i_ix ON scheduled_notifications (MOD(i, %[1]v), scheduled_for, notification_channel ASC); | |||
There was a problem hiding this comment.
This is not gonna do anything. U need to replace the index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telegram notifications + replies.
Depends on ice-blockchain/wintr#48