Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: logger #524

Merged
merged 11 commits into from
Jan 9, 2025
Merged

feat: logger #524

merged 11 commits into from
Jan 9, 2025
+421 −274

Conversation

ice-endymion
Copy link
Contributor

@ice-endymion ice-endymion commented Jan 8, 2025 •
edited
Loading

Description

Change of logging approach

Additional Notes

  • Refactor logging to have one logger
  • Use logger interface from NostrDart to control logs from app
  • Use TalkerDioLogger as Interceptor for ionIdentityClient to control logs from app
  • Integrate Talker package for logs
  • Add Debug menu, shake 👋 your phone or use hotkeys in simulators(🤖 cmd+m, 🍏 ctrl+cmd+z)
  • Refactor feature flags (logs can be on/off by feature flags)
  • Now you can export logs and share them

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Documentation
  • Chore

Screenshots

@ice-endymion ice-endymion requested review from a team as code owners January 8, 2025 20:29
@ice-endymion ice-endymion changed the title feat: Logger feat: logger Jan 8, 2025
@ice-endymion ice-endymion enabled auto-merge (squash) January 8, 2025 21:21
ice-alcides
ice-alcides previously approved these changes Jan 9, 2025
View reviewed changes
@ice-blockchain ice-blockchain deleted a comment from ice-kreios Jan 9, 2025
@ice-blockchain ice-blockchain deleted a comment from ice-ajax Jan 9, 2025
ice-alcides
ice-alcides previously approved these changes Jan 9, 2025
View reviewed changes
@ice-endymion ice-endymion merged commit ada521e into master Jan 9, 2025
1 check passed
@ice-endymion ice-endymion deleted the feature/logger branch January 9, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ice-ajax ice-ajax ice-ajax approved these changes

@ice-alcides ice-alcides ice-alcides approved these changes

@ice-hector ice-hector ice-hector approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ice-endymion @ice-hector @ice-alcides @ice-ajax