Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delete posts/articles/quotes/replies from the feed and profile #568

Merged
merged 27 commits into from
Jan 22, 2025

Conversation

ice-hector
Copy link
Contributor

@ice-hector ice-hector commented Jan 20, 2025

Description

This PR introduced ability to:

  • delete post
  • delete article
  • delete quote
  • unpost repost
  • delete reply
    from the feed and the profile tab and post/article/quote details screens

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Documentation
  • Chore

Screenshots (if applicable)

Screenshot 2025-01-20 at 09 54 54 Screenshot 2025-01-20 at 09 54 47 Screenshot 2025-01-20 at 09 54 37 Screenshot 2025-01-20 at 09 54 31 Screenshot 2025-01-20 at 09 54 27 Screenshot 2025-01-20 at 09 54 24

@ice-hector ice-hector requested review from a team as code owners January 20, 2025 07:58
@ice-kreios
Copy link
Contributor

in the screenshots i noticed that the context menu looks longer than it does in the Figma design.
Screenshot 2025-01-21 at 14 58 46

@ice-hector
Copy link
Contributor Author

ice-hector commented Jan 21, 2025

in the screenshots i noticed that the context menu looks longer than it does in the Figma design. Screenshot 2025-01-21 at 14 58 46

will be fixed in the scope of other PR, and should be discussed with the designer first.. when I implemented this PR design was like on screenshots (to be consistent with the feed menu items)

ice-alcides
ice-alcides previously approved these changes Jan 21, 2025
ice-kreios
ice-kreios previously approved these changes Jan 22, 2025
@ice-hector ice-hector dismissed stale reviews from ice-kreios and ice-alcides via 0b838d7 January 22, 2025 07:46
@ice-hector ice-hector merged commit 8a65963 into master Jan 22, 2025
1 check passed
@ice-hector ice-hector deleted the feature/delete-post branch January 22, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants