Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always increment quad, mesh, text and image layer counts in wgpu layer rendering #2701

Merged
merged 2 commits into from
Jan 26, 2025
Merged

always increment quad, mesh, text and image layer counts in wgpu layer rendering #2701

merged 2 commits into from
Jan 26, 2025

Conversation

edwloef
Copy link
Contributor

@edwloef edwloef commented Dec 19, 2024

Fixes #2700

@hecrj hecrj added this to the 0.14 milestone Jan 26, 2025
@hecrj hecrj added bug Something isn't working rendering wgpu fix labels Jan 26, 2025
hecrj
hecrj approved these changes Jan 26, 2025
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just hit this bug. Pesky one!

Thanks 🙇

@hecrj hecrj enabled auto-merge January 26, 2025 02:43
@hecrj hecrj merged commit c0db7b8 into iced-rs:master Jan 26, 2025
15 checks passed
@hecrj
Copy link
Member

hecrj commented Jan 26, 2025

In fact, I believe we can just avoid preparing these layers altogether as a simpler fix:

3428a3d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
bug Something isn't working fix rendering wgpu
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.

Layer rendering breaks if one is not drawn at any point
2 participants
@edwloef @hecrj