-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a feature to generate Swift enums with associated values #71
base: develop
Are you sure you want to change the base?
Add a feature to generate Swift enums with associated values #71
Conversation
…o_44 Update README with Xcode integration information
Release 0.6.1
...src/main/kotlin/dev/icerock/moko/kswift/plugin/feature/SealedToSwiftAssociatedEnumFeature.kt
Outdated
Show resolved
Hide resolved
@hbmartin thanks for contribution! can you show please example of generated code and kotlin source for this generated code? |
@Alex009 I added a test file that contains expected output at https://github.com/icerockdev/moko-kswift/pull/71/files#diff-6f9bcc9e1dfe050e77b438e13f7ecab7af5abbc22e6e44ddadeb8d0b4d708a38 |
.../src/main/kotlin/dev/icerock/moko/kswift/plugin/feature/associatedenum/AssociatedEnumCase.kt
Show resolved
Hide resolved
@Alex009 I don't plan any further work here now, we are using this in production and it is serving well. |
|
||
/** | ||
* selector: ClassContext/associatedenum/com/icerockdev/library/associatedenum/TestingSealed */ | ||
public enum TestingSealedKs { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so, as i see, this feature not about swift's associated types usage but improved version of SealedToEnum with correct pass of sealed internal data to enum internal data, yes? looks good!
TupleTypeName
inner types), hopefully upstreamed soon Add support for variable didSet and private(set) outfoxx/swiftpoet#70https://app.diagrams.net/#G18NIEe1pXeDIdozJ2Kv4hiNurb4vmwLdB